[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issues found by static analysis (patch)
From: |
Gavin Smith |
Subject: |
Re: Issues found by static analysis (patch) |
Date: |
Sun, 25 Apr 2021 16:18:39 +0100 |
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Mon, Mar 22, 2021 at 10:58:09AM +0100, Vitezslav Crhonek wrote:
> From 3d9e36af398e05f50fdd6ca72f2371f493fe6b45 Mon Sep 17 00:00:00 2001
> From: Vitezslav Crhonek <vcrhonek@redhat.com>
> Date: Wed, 17 Mar 2021 11:58:34 +0100
> Subject: [PATCH 7/8] Fix memory leak
>
> This is done at the end of the function, probably forgetfully omitted
> here.
> ---
> info/nodes.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/info/nodes.c b/info/nodes.c
> index 631e7af31c..3c941408e2 100644
> --- a/info/nodes.c
> +++ b/info/nodes.c
> @@ -480,6 +480,7 @@ get_tags_of_indirect_tags_table (FILE_BUFFER *file_buffer,
> }
> file_buffer->subfiles = NULL;
> free_file_buffer_tags (file_buffer);
> + free (subfiles);
> return;
> }
>
I made this change and also freed file_buffer->subfiles that was nulled
in an earlier line.