Re: configure enable xs fails because Texinfo/ModulePath.pm not found

[Gavin Smith]

On Thu, Feb 24, 2022 at 01:50:15PM +0100, Patrice Dumas wrote:
> Hello,
> 
> A ./configure in a devel pristine source shows
> 
> Can't locate Texinfo/ModulePath.pm in @INC (you may need to install the 
> Texinfo::ModulePath module) (@INC contains: . ../.. 
> /home/dumas/perl5/lib/perl5//x86_64-linux-gnu-thread-multi 
> /home/dumas/perl5/lib/perl5/ 
> /home/dumas/src/mini_ker_install/share/perl/5.32.1/ /etc/perl 
> /usr/local/lib/x86_64-linux-gnu/perl/5.34.0 /usr/local/share/perl/5.34.0 
> /usr/lib/x86_64-linux-gnu/perl5/5.34 /usr/share/perl5 
> /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.34 
> /usr/share/perl/5.34 /usr/local/lib/site_perl) at ../../Texinfo/XSLoader.pm 
> line 24.
> Compilation failed in require at ../../Texinfo/XS/TestXS.pm line 23.
> BEGIN failed--compilation aborted at ../../Texinfo/XS/TestXS.pm line 31.
> 
> for the TestXS test, because tp/Texinfo/XS/TestXS.pm requires 
> Texinfo::XSLoader
> which also require Texinfo::ModulePath, but at that point there is only
> tp/Texinfo/ModulePath.pm.in since tp/Texinfo/ModulePath.pm is created by
> a make run.
> 
> I am not sure about the best way to fix this, maybe move the relevant
> parts of Texinfo::XSLoader in Texinfo/XS/TestXS.pm, or have fallback
> values for $Texinfo::ModulePath::texinfo_uninstalled and
> $Texinfo::ModulePath::builddir if the require Texinfo::ModulePath; fails
> set in a BEGIN block.

It was "use Texinfo::ModulePath" until a couple of days ago when I changed
it to "require Texinfo::ModulePath", as until a change you made fairly
recently there was no line there at all, but adding "use Texinfo::ModulePath"
was incorrect as this led the initialization code to be run twice.  I'm not
sure why changing it from "use" to "require" would have broken it.  I will
try to investigate.