[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: EPUB tests using installed code
From: |
Patrice Dumas |
Subject: |
Re: EPUB tests using installed code |
Date: |
Sun, 7 Aug 2022 12:22:49 +0200 |
On Sun, Aug 07, 2022 at 10:24:54AM +0200, Patrice Dumas wrote:
> On Sat, Aug 06, 2022 at 11:44:42PM +0100, Gavin Smith wrote:
> >
> > I was getting test failures for two of the EPUB tests under tp/tests,
> > because they were using the installed modules. Even after I ran
> > "make install", the tests still failed, because the init files had moved
> > from init/ to ext/. It was only after I deleted the left-over files in
> > init/ that the tests passed.
> >
> > If EPUB is part of the test suite, then it must not use code from installed
> > locations when the test suite runs. If that means changing the search
> > path then that is what we must do.
>
> moving to ext/ and importing differently was actually the way to be more
> sure to use in source init files. But the tests need to be called with
> --epub3 and HTML_MATH, I didn't make that change systematically, will
> do. However this won't solve the case of tests using init files that
> are not considered as being internal extensions. It should be possible,
> however, to set differently include directories when TEST is set. I'll
> see what I can do if you don't do it first.
I did the change. Since it should be ok now, I won't change the use of
init files to replace with calls that lead to looking in ext only.
--
Pat