Re: change in tests requires running autogen.sh

[Gavin Smith]

On Wed, Jan 04, 2023 at 02:08:03PM +0100, Patrice Dumas wrote:
> Hello,
> 
> For those who follow the source version control, I changed the directories in
> tp/tests, which should require running ./autogen.sh to get things right,
> otherwise there may not be errors but still some tests would be ignored.

I ran autogen.sh and there is another test failure:

$ perl -w t/09indices.t index_table
ok 1
ok 2 - index_table tree
ok 3 - index_table sectioning
ok 4 - index_table nodes
ok 5 - index_table menus
ok 6 - index_table errors
ok 7 - index_table indices
ok 8 - index_table indices sort
ok 9 - index_table texi
ok 10 - index_table text
ok 11 - index_table converted file_info
ok 12 - index_table errors file_info
ok 13 - index_table converted file_html
ok 14 - index_table errors file_html
not ok 15 - index_table converted file_plaintext
#   Failed test 'index_table converted file_plaintext'
#   at t/../../tp/t/test_utils.pl line 1551.
# No index_table.txt in t/results/indices/index_table/out_plaintext
not ok 16 - index_table errors file_plaintext
#   Failed test 'index_table errors file_plaintext'
#   at t/../../tp/t/test_utils.pl line 1587.
1..16
# Looks like you failed 2 tests of 16.


The result file index_table.txt is present in
t/results/indices/index_table/res_plaintext/ but not in out_plaintext.
Should this file be generated by the test or should the reference file
be removed?

This test was recently touched by this change:

2023-01-01  Patrice Dumas  <pertusus@free.fr>

       * tp/t/09indices.t, tp/Makefile.tres: add test with index_table with
       default customization, rename former index_table as
       index_table_chapter_no_node.  Add explicit split nodes for Plaintext
       testing for index_nodes.  Split @file_encodings_tests out of
       @file_tests.  In @file_tests, do only testing of Info if it is
       expected to be different from the base case.  Keep spaces at end of
       line in test text only.


There are also changes to tp/Makefile.tres after building and running the
tests:

diff --git a/tp/Makefile.tres b/tp/Makefile.tres
index 1c93821fac..ecf229fb91 100644
--- a/tp/Makefile.tres
+++ b/tp/Makefile.tres
@@ -688,8 +688,11 @@ test_files_generated_list = 
$(test_tap_files_generated_list) \
   t/results/indices/double_seeentry_seealso.pl \
   t/results/indices/double_syncodeindex.pl \
   t/results/indices/empty_cindex_entry.pl \
+  t/results/indices/empty_cindex_entry/res_latex \
   t/results/indices/empty_index_entry.pl \
+  t/results/indices/empty_index_entry/res_latex \
   t/results/indices/empty_string_index_entry.pl \
+  t/results/indices/empty_string_index_entry/res_latex \
   t/results/indices/encoding_index_ascii.pl \
   t/results/indices/encoding_index_ascii/res_html \
   t/results/indices/encoding_index_ascii/res_info \
@@ -715,6 +718,7 @@ test_files_generated_list = 
$(test_tap_files_generated_list) \
   t/results/indices/encoding_index_utf8_enable_encoding/res_info \
   t/results/indices/encoding_index_utf8_enable_encoding/res_plaintext \
   t/results/indices/explicit_sort_key.pl \
+  t/results/indices/explicit_sort_key/res_latex \
   t/results/indices/ftable_vtable.pl \
   t/results/indices/ignored_sort_char_empty_entries.pl \
   t/results/indices/image_lines_count.pl \
@@ -804,6 +808,7 @@ test_files_generated_list = 
$(test_tap_files_generated_list) \
   t/results/indices/same_only_seealso_seeentry.pl \
   t/results/indices/same_seealso_seeentry.pl \
   t/results/indices/seealso_duplicate.pl \
+  t/results/indices/seealso_duplicate/res_latex \
   t/results/indices/seeentry.pl \
   t/results/indices/sorted_subentries.pl \
   t/results/indices/split_chapter_index.pl \
@@ -814,6 +819,7 @@ test_files_generated_list = 
$(test_tap_files_generated_list) \
   t/results/indices/syncode_index_print_both.pl \
   t/results/indices/syncodeindex_to_plain.pl \
   t/results/indices/transparent_sort_chars.pl \
+  t/results/indices/transparent_sort_chars/res_latex \
   t/results/indices/unknown_index_entry.pl \
   t/results/indices/unknown_printindex.pl \
   t/results/indices/unknown_synindex.pl \
@@ -1533,6 +1539,7 @@ test_files_generated_list = 
$(test_tap_files_generated_list) \
   t/results/raw/beginning_and_end_on_line.pl \
   t/results/raw/braces_in_tex.pl \
   t/results/raw/displaymath.pl \
+  t/results/raw/displaymath/res_html \
   t/results/raw/displaymath_not_closed.pl \
   t/results/raw/inline_in_example.pl \
   t/results/raw/inline_missing_first_arg.pl \

Should these be committed?

Running "make check" worked under tp/tests.  "make dist" also completes
successfully.