Re: set_labels_identifiers_target -fsanitize=undefined error

[John Paul Adrian Glaubitz]

Hi!

On Sat, 2023-11-04 at 12:03 +0100, John Paul Adrian Glaubitz wrote:
> Hi Gavin!
> 
> On Sat, 2023-11-04 at 11:00 +0000, Gavin Smith wrote:
> > The line in question is:
> > 
> >   memcpy (targets, list_of_labels, labels_number * sizeof(LABEL));
> > 
> > - again, the second argument of memcpy.
> > 
> > However, main/targets.c was only introduced after Texinfo 7.1 so
> > this is not the original problem.
> 
> I'll provide a backtrace as well as the commit that introduced the regression
> on SPARC within the next days. Need to set up two new SPARC servers next week
> first.

Here is the result of my bisect process:

(sid_sparc64-dchroot)glaubitz@stadler:~/texinfo$ git bisect bad                 
                                                                                
                                       
83259a78038068caf3f3d8d669796ea003a63735 is the first bad commit
commit 83259a78038068caf3f3d8d669796ea003a63735
Author: Gavin Smith <gavinsmith0123@gmail.com>   
Date:   Mon Apr 10 18:02:00 2023 +0100

    Run 'gnulib-tool --add-import obstack' under tp/Texinfo/XS.

 ChangeLog                               |   4 +
 tp/Texinfo/XS/gnulib/lib/Makefile.am    |  33 ++
 tp/Texinfo/XS/gnulib/lib/alignof.h      |  51 +++
 tp/Texinfo/XS/gnulib/lib/exitfail.c     |  24 ++
 tp/Texinfo/XS/gnulib/lib/exitfail.h     |  18 ++
 tp/Texinfo/XS/gnulib/lib/gettext.h      | 300 ++++++++++++++++++
 tp/Texinfo/XS/gnulib/lib/obstack.c      | 353 +++++++++++++++++++++
 tp/Texinfo/XS/gnulib/lib/obstack.h      | 546 ++++++++++++++++++++++++++++++++
 tp/Texinfo/XS/gnulib/m4/gnulib-cache.m4 |   2 +
 tp/Texinfo/XS/gnulib/m4/gnulib-comp.m4  |  18 ++
 tp/Texinfo/XS/gnulib/m4/obstack.m4      |  33 ++
 tp/Texinfo/XS/gnulib/m4/vararrays.m4    |  72 +++++
 tp/Texinfo/XS/parsetexi/tree.c          |   2 +-
 13 files changed, 1455 insertions(+), 1 deletion(-)
 create mode 100644 tp/Texinfo/XS/gnulib/lib/alignof.h
 create mode 100644 tp/Texinfo/XS/gnulib/lib/exitfail.c
 create mode 100644 tp/Texinfo/XS/gnulib/lib/exitfail.h
 create mode 100644 tp/Texinfo/XS/gnulib/lib/gettext.h
 create mode 100644 tp/Texinfo/XS/gnulib/lib/obstack.c
 create mode 100644 tp/Texinfo/XS/gnulib/lib/obstack.h
 create mode 100644 tp/Texinfo/XS/gnulib/m4/obstack.m4
 create mode 100644 tp/Texinfo/XS/gnulib/m4/vararrays.m4
(sid_sparc64-dchroot)glaubitz@stadler:~/texinfo$

I'll test the proposed patch now.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913