Re: set_labels_identifiers_target -fsanitize=undefined error

[Gavin Smith]

On Sun, Nov 12, 2023 at 12:41:58PM +0100, John Paul Adrian Glaubitz wrote:

> > diff tree.c.old tree.c -u
> > --- tree.c.old  2023-11-04 16:15:13.632755680 +0000
> > +++ tree.c      2023-11-04 16:16:36.211072521 +0000
> > @@ -43,7 +43,10 @@
> >    if (obs_element_first)
> >      obstack_free (&obs_element, obs_element_first);
> >    else
> > -    obstack_init (&obs_element);
> > +    {
> > +      obstack_alignment_mask (&obs_element) = 7; /* 8-byte alignment */
> > +      obstack_init (&obs_element);
> > +    }
> >  
> >    obs_element_first = obstack_alloc (&obs_element, sizeof (int));
> > 
> > 
> > Can you check if that works?
> 
> Yes, I can confirm that this patch fixes the crash for me.
> 
> Would be great if this fix could be included for the next release!

I've added it to the release branch so if there is ever a Texinfo 7.1.1
release, it will be included.  In the current development code, there
are significant changes and obstacks don't appear to be used at all,
making it a moot point.

The problem should probably to be reported to the gnulib developers to
investigate why incorrectly aligned memory was being returned.