[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: ffmpeg documentation no longer builds after Texinfo 7.1 (due to --in
From: |
Patrice Dumas |
Subject: |
Re: ffmpeg documentation no longer builds after Texinfo 7.1 (due to --init-file=) |
Date: |
Sun, 28 Jan 2024 12:12:29 +0100 |
On Sun, Jan 28, 2024 at 12:16:42AM +0000, Gavin Smith wrote:
> > If there is still a customization variable to access for this, then
> > I don't see why the name has to be changed. I haven't had any new thoughts
> > on this since my previous emails on the topic, I'm afraid. I remember
> > that not using PACKAGE_VERSION was mainly due to a clash with a symbol
> > defined by automake or autoconf, which is an implementation problem that
> > we could try to work around, rather than changing our public interface.
> > I'll try to propose a change once I've had time to look at it.
>
> Here's the patch to change it back to PACKAGE_VERSION. I defined macros
> with the original values using a _CONFIG suffix as you suggested, which
> is needed in one place in the code (in the argument to bindtextdomain).
Looks good to me. I think that there should also be the names with
_CONFIG prependend available through Texinfo::Common::get_constant() (or
whatever name is used for this function). I can add them later on.
--
Pat