Re: Build from git broken - missing gperf?

[Patrice Dumas]

On Mon, Feb 05, 2024 at 07:35:59PM +0000, Gavin Smith wrote:
> I don't know if uniconv/u8-conv-from-enc is a necessary module.  It's
> not easy to find out how the module is used as the documentation is
> lacking, but it appears to match libunistring.  The documentation is
> here:
> https://www.gnu.org/software/libunistring/manual/html_node/uniconv_002eh.html
> 
> I found uses of "u8_strconv_from_encoding" throughout the XS code,
> although most of the uses (I didn't check them all) have "UTF-8" as one
> of the arguments, making it appear that we are converting from UTF-8
> to UTF-8.

It is the case.  We actually already discussed that issue peviously, in
the codes I did, and in order to follow what I understood from the
libunistring documentation, char * is converted to uint8_t by calling
u8_strconv_from_encoding even though the string is already UTF-8.  In
your code in xspara.c you simply cast to uint8_t.  It could also be done
like that in other codes, I do not know what is best.

That being said, we also directly use gnulib iconv, so I think that
iconv_open would still be brought in anyway.

-- 
Pat