Intermittent test failure in t/03coverage_braces.t definfoenclose_texinfo_commands

[Gavin Smith]

I occasionally get test failures in the
"perl -w t/03coverage_braces.t definfoenclose_texinfo_commands" test,
but cannot usually repeat it reliably.  I suspect some issue with memory
corruption or issue with uninitialised memory, although I've not managed
to get anything to show up with valgrind so far.

To get it to fail, I need to do
"while perl -w t/03coverage_braces.t  ; do true ; done"
and then wait a while.

Here is the result of
"diff t/results/coverage_braces/definfoenclose_texinfo_commands.pl*"
on one of the occasions I was able to get it to fail after running
"TEXINFO_XS=require perl -w t/03coverage_braces.t".

The code was changed recently (2024-02-18, commit b447793774).


85c85,93
<                   'text' => 'strong,(,)'
---
>                   'text' => 'strong'
>                 }
>               ],
>               'type' => 'line_arg'
>             },
>             {
>               'contents' => [
>                 {
>                   'text' => '(,)'
98,104d105
<           'extra' => {
<             'misc_args' => [
<               'strong',
<               '(',
<               ')'
<             ]
<           },
215,221d215
<               'extra' => {
<                 'begin' => '(',
<                 'end' => ')'
<               },
<               'info' => {
<                 'command_name' => 'strong'
<               },
224,225c218
<               },
<               'type' => 'definfoenclose_command'
---
>               }
316c309
< @definfoenclose strong,(,)
---
> @definfoenclose strong(,)
374a368,374
>     'error_line' => 'bad argument to @definfoenclose
> ',
>     'line_nr' => 3,
>     'text' => 'bad argument to @definfoenclose',
>     'type' => 'error'
>   },
>   {
397c397
<    TeX.  (in strong).
---
>    TeX.  *in strong*.
406c406
< <p>TeX. (in strong).
---
> <p>TeX. <strong class="strong">in strong</strong>.


On another occasion, the diff was different:

$ diff t/results/coverage_braces/definfoenclose_texinfo_commands.pl*
119c119,127
<                   'text' => 'quotation,q,e'
---
>                   'text' => 'quotation'
>                 }
>               ],
>               'type' => 'line_arg'
>             },
>             {
>               'contents' => [
>                 {
>                   'text' => 'q,e'
132,138d139
<           'extra' => {
<             'misc_args' => [
<               'quotation',
<               'q',
<               'e'
<             ]
<           },
317c318
< @definfoenclose quotation,q,e
---
> @definfoenclose quotationq,e
382c383
<     'error_line' => 'cannot redefine with @definfoenclose: quotation
---
>     'error_line' => 'bad argument to @definfoenclose
385c386
<     'text' => 'cannot redefine with @definfoenclose: quotation',
---
>     'text' => 'bad argument to @definfoenclose',

Here is the contents of the test case:

['definfoenclose_texinfo_commands',
'@definfoenclose verb,;;,!!
@definfoenclose TeX,aa,bb
@definfoenclose strong,(,)
@definfoenclose quotation,q,e

@verb{*aaa*}.

@TeX{}. @strong{in strong}.

@quotation important
in quotation
@end quotation
'],