Re: Texinfo 7.1.0.90 pretest results [OpenBSD 7.5]

[Bruno Haible]

Gavin Smith wrote:
> I tried to fix one problem on the master branch (commit 2ae196b9807a,
> 2024-06-09).

Since you mention the master branch, I ran the same build recipe on the
master branch. Results (compared with the release/7.1 branch):

1) On OpenBSD, the error "Can't locate Texinfo/Commands.pm in @INC" is
indeed gone.

2) On macOS 11..13, there is a compilation error:

-------------------------------------------------------------------------------
libtool: compile:  cc -DHAVE_CONFIG_H -I. -I../../../../tp/Texinfo/XS 
-I../../../../tp/Texinfo/XS/main -I../../../../tp/Texinfo/XS/parsetexi 
-I../../../../tp/Texinfo/XS -DDATADIR=\"/usr/local/share\" 
-I../../../../tp/Texinfo/XS/gnulib/lib -I./gnulib/lib -I/Users/runner/include 
-I/usr/local/opt/gettext/include -Wall -I/usr/local/include -MT 
main/libtexinfo_la-manipulate_indices.lo -MD -MP -MF 
main/.deps/libtexinfo_la-manipulate_indices.Tpo -c 
../../../../tp/Texinfo/XS/main/manipulate_indices.c  -fno-common -DPIC -o 
main/.libs/libtexinfo_la-manipulate_indices.o
../../../../tp/Texinfo/XS/main/manipulate_indices.c:281:7: error: unknown type 
name 'locale_t'
      locale_t locale;
      ^
../../../../tp/Texinfo/XS/main/manipulate_indices.c:306:27: error: implicit 
declaration of function 'strxfrm_l' is invalid in C99 
[-Werror,-Wimplicit-function-declaration]
          sort_key->len = strxfrm_l (0, sort_string, 0, collator->coll.locale);
                          ^
../../../../tp/Texinfo/XS/main/manipulate_indices.c:306:27: note: did you mean 
'strxfrm'?
/Applications/Xcode_13.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/string.h:91:9:
 note: 'strxfrm' declared here
size_t   strxfrm(char *__s1, const char *__s2, size_t __n);
         ^
../../../../tp/Texinfo/XS/main/manipulate_indices.c:597:15: error: implicit 
declaration of function 'newlocale' is invalid in C99 
[-Werror,-Wimplicit-function-declaration]
            = newlocale (LC_COLLATE_MASK, collation_locale, 0);
              ^
../../../../tp/Texinfo/XS/main/manipulate_indices.c:597:15: note: did you mean 
'setlocale'?
/Applications/Xcode_13.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/locale.h:53:8:
 note: 'setlocale' declared here
char            *setlocale(int, const char *);
                 ^
../../../../tp/Texinfo/XS/main/manipulate_indices.c:597:26: error: use of 
undeclared identifier 'LC_COLLATE_MASK'
            = newlocale (LC_COLLATE_MASK, collation_locale, 0);
                         ^
../../../../tp/Texinfo/XS/main/manipulate_indices.c:891:5: error: implicit 
declaration of function 'freelocale' is invalid in C99 
[-Werror,-Wimplicit-function-declaration]
    freelocale (collator->coll.locale);
    ^
../../../../tp/Texinfo/XS/main/manipulate_indices.c:891:5: note: did you mean 
'setlocale'?
/Applications/Xcode_13.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/locale.h:53:8:
 note: 'setlocale' declared here
char            *setlocale(int, const char *);
                 ^
5 errors generated.
make[5]: *** [main/libtexinfo_la-manipulate_indices.lo] Error 1
-------------------------------------------------------------------------------

I would guess that the cause is a missing '#include <locale.h>'.

3) The OpenBSD build fails like this:
-------------------------------------------------------------------------------
Making all in man
Updating man page install-info.1
cd ..//install-info && make ginstall-info
`ginstall-info' is up to date.
/bin/sh 
/home/runner/work/ci-check/ci-check/texinfo-7.1.90-20240610/build-aux/missing 
help2man --name="update info/dir entries" -I ../../man/ginstall-info.h2m 
..//install-info/ginstall-info -o install-info.1
/home/runner/work/ci-check/ci-check/texinfo-7.1.90-20240610/build-aux/missing[81]:
 help2man: not found
WARNING: 'help2man' is missing on your system.
         You should only need it if you modified a dependency of a man page.
         You may want to install the GNU Help2man package:
         <https://www.gnu.org/software/help2man/>
*** Error 127 in man (Makefile:2112 'install-info.1': @name="update info/dir 
entries" && echo "Updating man page install-info.1"  && exe_ext...)
*** Error 1 in . (Makefile:1947 'all-recursive': @fail=;  if (target_option=k; 
case ${target_option-} in  ?) ;;  *) echo "am__make_running_w...)
*** Error 2 in 
/home/runner/work/ci-check/ci-check/texinfo-7.1.90-20240610/build 
(Makefile:1861 'all')
-------------------------------------------------------------------------------

help2man is meant to be needed when building from git, according to
README-hacking. But here, I'm building from a tarball. Why is help2man
needed in this situation?

4) The Solaris 11 OmniOS build fails due to a test failure:

FAIL: test_scripts/encoded_non_ascii_test_epub.sh

Detailed log:
-------------------------------------------------------------------------------

FAIL: test_scripts/encoded_non_ascii_test_epub.sh
=================================================

D: encoded/diffs/non_ascii_test_epub.diff (printed below)
Common subdirectories: 
../../../tp/tests/encoded/res_parser/non_ascii_test_epub/osé_utf8_epub_package 
and encoded/out_parser/non_ascii_test_epub/osé_utf8_epub_package
Common subdirectories: 
../../../tp/tests/encoded/res_parser/non_ascii_test_epub/osé_utf8_epub_package/EPUB
 and encoded/out_parser/non_ascii_test_epub/osé_utf8_epub_package/EPUB
Common subdirectories: 
../../../tp/tests/encoded/res_parser/non_ascii_test_epub/osé_utf8_epub_package/META-INF
 and encoded/out_parser/non_ascii_test_epub/osé_utf8_epub_package/META-INF
Only in 
../../../tp/tests/encoded/res_parser/non_ascii_test_epub/osé_utf8_epub_package/EPUB:
 0
Common subdirectories: 
../../../tp/tests/encoded/res_parser/non_ascii_test_epub/osé_utf8_epub_package/EPUB/images
 and encoded/out_parser/non_ascii_test_epub/osé_utf8_epub_package/EPUB/images
Common subdirectories: 
../../../tp/tests/encoded/res_parser/non_ascii_test_epub/osé_utf8_epub_package/EPUB/xhtml
 and encoded/out_parser/non_ascii_test_epub/osé_utf8_epub_package/EPUB/xhtml
D: encoded/diffs/non_ascii_test_epub.diff (printed above)
testdir: encoded
driving_file: ../../../tp/tests/encoded/list-of-tests
made result dir: ../../../tp/tests/encoded/res_parser/

doing test non_ascii_test_epub, src_file ../../../tp/tests/encoded/osé_utf8.texi
format_option: 
texi2any.pl non_ascii_test_epub -> encoded/out_parser/non_ascii_test_epub
 /usr/bin/perl -w ../../../tp/tests/..//texi2any.pl  --force --conf-dir 
../../../tp/tests/../t/init/ --conf-dir ../../../tp/tests/../init --conf-dir 
../../../tp/tests/../ext -I ../../../tp/tests/encoded -I encoded/ -I 
../../../tp/tests/ -I . -I built_input --error-limit=1000 -c TEST=1  --output 
encoded/out_parser/non_ascii_test_epub/ -D 'needcommandlineunicode Need 
command-line unicode' -c COMMAND_LINE_ENCODING=UTF-8 -c MESSAGE_ENCODING=UTF-8 
-c OUTPUT_FILE_NAME_ENCODING=UTF-8 --init epub3.pm -c 
'EPUB_CREATE_CONTAINER_FILE 0' ../../../tp/tests/encoded/osé_utf8.texi > 
encoded/out_parser/non_ascii_test_epub/osé_utf8.1 
2>encoded/out_parser/non_ascii_test_epub/osé_utf8.2

all done, exiting with status 1
FAIL test_scripts/encoded_non_ascii_test_epub.sh (exit status: 1)
-------------------------------------------------------------------------------

Bruno