Re: [Chicken-hackers] [PATCH] Fix panic in decode_literal() on flonum literals

[Felix]

> The attached patch (or changeset 96286a7a7144b17e4b7a3f08164fb6d6296f1722
> in sjamaan-pending) fixes this problem by calling
> convert_string_to_number() instead of strtol()/strtod().
> I didn't really understand the purpose of the maybe_fixnum variable, so
> I'd appreciate it if Felix or someone else who groks this can comment
> on whether this fix is correct.

The encoded literal may be a fixnum on 64-bit machines, even when it
overflows on a 32-bit machine. But the flag is always set in the
FLONUM case, so it looks like it is redundant.


cheers,
felix