chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] proposed bugfix for #706


From: Christian Kellermann
Subject: Re: [Chicken-hackers] [PATCH] proposed bugfix for #706
Date: Thu, 29 Sep 2011 09:25:21 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

* felix winkelmann <address@hidden> [110929 03:18]:
> I would suggest simply to detect the error in C_file_info_2, and act
> accordingly (by calling whatever stupid POSIX API that has to be used
> for this, probably incompatible with the way stupid Windows does it,
> and all the stupid crap programmers have to put up with nowadays) and
> using a flonum for the size-slot in the file info vector.

I am not quite sure I understand this correctly. Catch the error
and if it is an overflow, redo it with a flonum? I am not sure if
this is even possible since the internal check is against whether
you are a 32-bit application and your off_t datatype is large enough
to hold the size.

My manpage here suggests compiling with -D_FILE_OFFSET_BITS=64 in
this case to make this error go away.  (Silly I know).

So we could fix this particular bug by passing another magic define
around.  I am fine with that it would be least invasive.

For all the other errors we still need to add checks IMHO. This
should also include a sane way to report them (have you seen the
bug #707?).

Thanks,

Christian

-- 
Who can (make) the muddy water (clear)? Let it be still, and it will
gradually become clear. Who can secure the condition of rest? Let
movement go on, and the condition of rest will gradually arise.
 -- Lao Tse. 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]