Re: [Chicken-hackers] [PATCH] Fix #1080 (condition-case warnings)

[Christian Kellermann]

* Peter Bex <address@hidden> [131213 21:57]:
> Hi all,
> 
> As Christian rightfully noticed, we now generate spurious notices for
> condition-case with normal "fallback" entries due to the change in
> cond that detects clauses following an "else".
> 
> Attached is the simplest fix I could come up with.  I also made a
> version which gives a friendlier notice (detection is done in
> condition-case itself, so it can show the offending source clause)
> but unfortunately it's a bit ugly and much longer (45 lines versus
> the current 30 lines) so I decided to scrap it.

After some trials by Peter to give better warnings in case the user
writes two catch-all clauses, we decided on IRC that all the other
approaches are way more complicated than this simple fix. After all
it removes an warning the user has no influence over, but does not
prevent the user to write awful code.

Hence, this patch has been pushed.

Thanks Peter,

Christian


-- 
In the world, there is nothing more submissive and weak than
water. Yet for attacking that which is hard and strong, nothing can
surpass it. --- Lao Tzu