[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Fix MAKEDIR_COMMAND when INSTALL_PROGRAM i
|
From: |
Michele La Monaca |
|
Subject: |
Re: [Chicken-hackers] [PATCH] Fix MAKEDIR_COMMAND when INSTALL_PROGRAM is set |
|
Date: |
Sun, 14 Jun 2015 10:41:45 +0200 |
On Sat, Jun 13, 2015 at 3:10 PM, Peter Bex <address@hidden> wrote:
> On Fri, Jun 12, 2015 at 04:16:30PM +0200, Michele La Monaca wrote:
>> Hi,
>>
>> I've noticed that INSTALL_PROGRAM is not used to create directories.
>> The attached patch fixes this behavior.
>
> Hi Michele,
>
> Thanks for your patch. It looks good to me, signed off version attached.
> This applies to master as well as chicken-5.
>
> I'd cautiously say this should probably go into the prerelease branch,
> but I don't quite understand why the Solaris makefiles work without
> this patch: it needs INSTALL_PROGRAM=ginstall, but maybe the "install"
> program is compatible enough to simply make directories?
Yes, Solaris’s install programs kicks in and correctly creates the
directories. Undoubtedly, this patch should go in 4.10.0, too. I would
also add some mention of this variable in the README.
Regards,
Michele