Re: [Chicken-hackers] [PATCH] Fix a logical bug in the optimizer

[Peter Bex]

On Sun, Apr 02, 2017 at 09:14:01PM +0200, address@hidden wrote:
> I don't fully understand your remark, but the point is that the a conditional
> results in an unknown execution path. A call on the other hand may
> result in all possible things (access of the 1st def of "foo" above, for
> example). As I said, this pass should be rewritten.
> 

Maybe we can do that later.  For now I think this patch is fine, so here's
a signed off copy.  Note that this applies cleanly to master, too.

> > Also, should this also treat the newly added "define-toplevel" core
> > expression like it treats set!?
> 
> Yes, it should.


I just checked, but after canonicalisation, define-toplevel no longer
exists; like ##core#set, ##core#define-toplevel is rewritten to
simply set!, so the optimizer can stay unchanged.

Cheers,
Peter

0001-Fix-a-bug-in-scan-toplevel-assignments-walk-routine.patch
Description: Text Data

signature.asc
Description: Digital signature