chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Chicken-hackers] [PATCH] Fix #1362 and simplify macro-renaming a bit


From: Peter Bex
Subject: [Chicken-hackers] [PATCH] Fix #1362 and simplify macro-renaming a bit
Date: Fri, 14 Apr 2017 17:44:41 +0200
User-agent: Mutt/1.5.23 (2014-03-12)

Hi all,

This ticket was reported a few days ago, and it's a reasonably easy fix.
When looking up an identifier, we look it up in the current syntactic
environment (SE) and if that fails, we check its '##core#macro-alias
property, if any, and return it.

This behaviour is fine when looking up identifiers: it may have been
renamed, so we need to look up its actual value.  But when renaming,
this is not fine, because that effectively _undoes_ the rename (if
it was renamed before).  So instead of using "lookup", rename now
performs just the alist lookup itself.

This bug affects master as well, so I think it's a good idea to fix
it there too (see attached patches, there was a small conflict so
I added patches for both versions).

Cheers,
Peter

Attachment: 0001-Do-not-undo-macro-renaming-when-renaming-twice.master.patch
Description: Text Data

Attachment: 0002-Remove-unnecessary-double-alias-for-already-aliased-.master.patch
Description: Text Data

Attachment: 0001-Do-not-undo-macro-renaming-when-renaming-twice.chicken-5.patch
Description: Text Data

Attachment: 0002-Remove-unnecessary-double-alias-for-already-aliased-.chicken-5.patch
Description: Text Data

Attachment: signature.asc
Description: Digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]