chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH][5] Three small patches


From: Peter Bex
Subject: Re: [Chicken-hackers] [PATCH][5] Three small patches
Date: Sat, 6 May 2017 14:25:39 +0200
User-agent: Mutt/1.5.23 (2014-03-12)

On Wed, May 03, 2017 at 09:17:35PM +0200, lemonboy wrote:
> Hello hackers,
> here are some small patches that fix some small problems I found while
> playing around.

Thanks!  I have pushed your first patch, as that is an obvious fix to a
problem that's easily triggered.

Attached are signed-off copies of your other two patches.  I have rebased
a bit to add the tests to the corresponding patch rather than as a
separate patch.

I've also added the new file tests/c-id-valid.scm to the distribution
manifest, and added the new test to runtest.bat so that it can also be
used on Windows.  I noticed another problem on Windows though, so I'll
send another patch soon.

Technically the C identifier patch could also go to master, but it's too
much of a hassle for little gain.  If someone wants to put in the effort,
please feel free to do so.

Cheers,
Peter

Attachment: 0001-Fix-the-check-for-valid-C-identifiers.patch
Description: Text Data

Attachment: 0002-Show-the-location-in-some-more-error-messages.patch
Description: Text Data

Attachment: signature.asc
Description: Digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]