[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH 3/3] Fix repository searching for "-link" f
From: |
Peter Bex |
Subject: |
Re: [Chicken-hackers] [PATCH 3/3] Fix repository searching for "-link" flag and associated tests |
Date: |
Sun, 25 Jun 2017 12:35:46 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Wed, Jun 21, 2017 at 12:01:48PM +1200, Evan Hanson wrote:
> On 2017-06-20 13:11, address@hidden wrote:
> > You seem to drop the reference to "destination-repository". Are you sure
> > this is
> > right in the face of cross-compilation?
>
> I think so. Or rather, this patch makes "-link" behave like "normal"
> compilation in that it respects CHICKEN_REPOSITORY_PATH and the
> "repository-path" parameter, which is what we want, I think. Previously,
> it would ignore those values and go straight to the target repo, so
> something/lib/chicken/9, since the "destination-repository" helper
> doesn't seem to consider C_R_P at all. I might be missing something,
> though. How is C_R_P intended to behave when cross-compiling?
I've pushed the first two patches, as they're obviously correct (we've
applied them before). I don't quite understand how dropping the
destination-repository host/target selection will impact cross-
compilation. Felix, can you answer Evan's question and perhaps
review the third patch?
Cheers,
Peter
signature.asc
Description: PGP signature