Re: [Chicken-hackers] [PATCH] Fix for Windows quoting issues (fixes #1515)

[Peter Bex]

On Sun, Sep 02, 2018 at 12:27:26PM +0200, address@hidden wrote:
> Yes, I know about the instructions in the README. This only affects what gets
> stored in chicken-config.h. Slashification must take place for all paths that 
> get
> passed to the DOS shell and which are not arguments passed further on to 
> invoked
> programs (the Windows API accepts forward slashes, but cmd.exe, when using
> pathnames that contain slashes will fail. So all paths _directly_ used by 
> cmd.exe
> (paths to programs and, I assume, paths given to builtin commands (mkdir, 
> etc?))
> must use backslashes.
> 
> I do not claim that the original code was totally consistent or fully 
> correct, but don't
> mess with these things in too lighthearted a manner, as it took ages to get 
> C4 csc +
> chicken-install do the right thing.

OK, attached is a new patch that keeps slashification where it was
already present (except for shell variables; those don't have to be
quoted or slashified).  I decided to move the slashification into "qs*"
so that it's easier to add or remove slashification on any given call.

From a quick glance through the new code, it seems there are very few
calls where we actually don't slashify.  Perhaps for 5.1 we can try
dropping the optional "slashify?" argument and make it slashify always.

Cheers,
Peter

0001-Fix-quotation-in-scripts-generated-by-chicken-instal.patch
Description: Text Data

0002-Fix-type-declaration-for-qs-procedure.patch
Description: Text Data

signature.asc
Description: PGP signature