Re: [Chicken-hackers] Regarding #1564: srfi-18: (mutex-unlock) Internal scheduler error

[Kon Lovett]

see attached git (C4) & svn (C5) logs

#(in C4 core local repo)
git log --follow -p -- srfi-18.scm >srfi-18.log

#(in C5 svn local repo)
svn log --diff trunk >srfi-18_trunk-diff.log

hth

> On Dec 2, 2018, at 1:19 PM, Jörg F. Wittenberger <address@hidden> wrote:
> 
> Thanks for the replies,
> 
> chicken-install -r srfi-18 ;  did the trick already
> 
> I should have stated that that's what I have, what I've been looking for was 
> the git history. I wonder for some statements why the hell they are there at 
> all. Two possible reasons: a) I cleaned them up for being obsolete (due to 
> former changes I made) b) removed since I touched the file, which begs the 
> question "why where those added".
> 
> Never mind.  I can proceed at least.
> 
> On Dec 2 2018, Kon Lovett wrote:
> 
>> well, that shows me. ;-)
>> 
>> trying to track down why 
>> #497 $ chicken-install -r srfi-18
>> mapped (srfi-18) to ()
>> retrieving ...
>> 
>> 
>>> On Dec 2, 2018, at 10:42 AM, Kon Lovett <address@hidden> wrote:
>>> C5 evicted srfi-18, along w/ srfi-1, 13, 14, & 69, to the egg store.
>>> chicken-install -retrieve.
>>>> On Dec 2, 2018, at 10:39 AM, Jörg F. Wittenberger <address@hidden> wrote:
>>>> Hi all,
>>>> when I tried to reply in a timely manner I apparently sent out a link to a 
>>>> broken file. Sorry for that.
>>>> Just wanted to see if I could create a patch for the current master.
>>>> For this I need srfi-18 egg source too.  Just I can't find it.
>>>> Jöry
>>>> On Nov 30 2018, Jörg F. Wittenberger wrote:
>>>>> Hello Megane,
>>>>> On Nov 30 2018, megane wrote:
>>>>>> Hi,
>>>>>> Here's another version that crashes quickly with "very high
>>>>>> probability".
>>>>> ...
>>>>>> 24 Error: (mutex-unlock) Internal scheduler error: unknown thread state
>>>>>> 25       #<thread: thread1>
>>>>>> 26       ready
>>>>> This bears an uncanny resemblance to scheduler issues I've been fighting 
>>>>> a long ago.
>>>>> Too long to ago.
>>>>>> --- A fix
>>>>>> Just allow the 'ready state for threads in mutex-unlock!
>>>>>> ...
>>>>>> Is this a correct fix?
>>>>> Too long ago.
>>>>> But it feels wrong. We'd rather make sure there is no ready thread in the 
>>>>> queue waiting for a mutex in the first place.
>>>>> Diffing the changes I maintained quite a while back 
>>>>> http://ball.askemos.org/Ad60e3fb123a79b2e5128915116b288f7/chicken-4.9.1-ball.tar.gz
>>>>>  you will find that I added a
>>>>> ##sys#thread-clear-blocking-state!
>>>>> Towards the end of scheduler.scm and used it for consistency whereever I 
>>>>> ran into not-so-clean unlocks.
>>>>> Now this is still an invasive change. But looking at the source of 
>>>>> scheduler and srfi-18 in chicken 5 right now, I can't fight the feeling 
>>>>> that it is working around the missing changes at several places.
>>>>> Best
>>>>> /Jörg
>>>>> _______________________________________________
>>>>> Chicken-hackers mailing list
>>>>> address@hidden
>>>>> https://lists.nongnu.org/mailman/listinfo/chicken-hackers
>>>> _______________________________________________
>>>> Chicken-hackers mailing list
>>>> address@hidden
>>>> https://lists.nongnu.org/mailman/listinfo/chicken-hackers
>> 
>>

srfi-18.log
Description: Binary data

srfi-18_trunk-diff.log
Description: Binary data