chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Chicken-hackers] [PATCH] Fix #1625 and add srfi-88 module plus feature


From: Peter Bex
Subject: [Chicken-hackers] [PATCH] Fix #1625 and add srfi-88 module plus feature identifier
Date: Sat, 29 Jun 2019 17:10:04 +0200
User-agent: NeoMutt/20170113 (1.7.2)

Hi all,

Pretty straightforward patch.  I decided to get rid of the mutation
of pkw and use it in "loop" because I found it a bit confusing to
have skw in the loop and pkw as a mutable lexical var, so sorry
for the large patch.  It doesn't really change all that much.

Other than moving pkw into the loop args, we need to remember if
the expression was pipe-quoted so I added that as an additional
argument for "loop".  This needs to be checked when encountering
a : when it's the first thing we've seen in prefix mode.  If there
were quote bars before the colon, it's not really the first thing,
so it shouldn't be seen as a keyword.

Finally we add an "or quoted" check to the empty list check when
deciding whether to make a keyword or a symbol.

The second patch completes SRFI-88 support by registering a module
for it and adding the feature identifier (which I think was just an
oversight).  Strictly speaking, we might not define the identifier
when keyword mode is prefix or none, but then we still do have the
srfi-88 procedures, so I'm not 100% sure.

We could let the features procedure check the keyword style and add
srfi-88 dynamically if it's #:suffix only...

Cheers,
Peter

Attachment: 0001-Read-quoted-empty-keywords-as-keywords.patch
Description: Text Data

Attachment: 0002-Define-a-srfi-88-module-as-a-subset-of-chicken.keywo.patch
Description: Text Data

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]