[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix decompose-directory and change drives before attempting
From: |
Evan Hanson |
Subject: |
Re: [PATCH] Fix decompose-directory and change drives before attempting to build eggs on Windows |
Date: |
Mon, 11 Nov 2019 21:02:54 +1300 |
Hi Peter,
On 2019-11-09 17:15, Peter Bex wrote:
> I had a look at #1647 and the fix seems to me to be pretty
> straightforward. The build.bat which chicken-install creates
> contains a "cd" command, but on Windows, cd won't change to
> the corresponding drive, so when we then try to compile the
> source file, we'll get an error because we're still on the other
> drive.
>
> The fix is to first switch drives, then run cd.
>
> While working on this, I discovered that decompose-directory crashes
> on Windows when the path has a drive in it, so the first patch first
> fixes that bug, the second patch actually fixes the bug from the ticket.
That all makes sense, thanks for investigating this. I've applied both
of these, and a quick test on Windows shows everything is OK.
Cheers,
Evan
signature.asc
Description: PGP signature