Re: [PATCH] fix chicken-install http download bug

[Mario Domenech Goulart]

On Sun, 16 Jul 2023 12:25:25 +0200 felix.winkelmann@bevuta.com wrote:

> The attached patch fixes a problem with chicken-install that caused eggs
> transmitted via HTTP to be rejected due to a malformed version number.
> Specifically, "-" was not allowed inside version numbers, and the monocypher
> egg seemed to be the first one using such a versioning scheme.
>
> The patch allows anything bug space and vertical bar and is slightly more
> strict regarding the format.
>
> Thanks to "kniffy" for reporting this and Mario for investigating.

Thanks, Felix.  I've pushed your patch.

I've tested it fetching the egg from kitten-techs:

  $ ~/chicken-test/builds/master-tcc/bin/chicken-status monocypher
  monocypher .......................................... version: 4.0.1-0

I wonder if we could use something that matches more strictly what
henrietta sends.  Something like

  "#\\|-{20} +([^| ]*) \\|#.*"

Anyway, if that's the case, it can be changed later.  The current patch
fixes the problem.

Regarding the situation of the infrastructure:

* call-cc.org's cache has been fixed (i.e., monocypher 4.0.1-0 has been
  removed, and 4.0.1 has been cached -- contents should be identical).
  monocypher can be installed from there.

* kitten-techs' cache at the time of this writing still has monocypher
  4.0.1-0, so chicken-install without the attached patch will fail to
  install it from there.  I've requested Alaric to remove 4.0.1-0, as
  that breaks the installation of monocypher with the current CHICKEN
  release.

* The eggs-5-latest git repository has been manually updated to ship
  4.0.1.

All the best.
Mario
-- 
http://parenteses.org/mario