Re: [cp-patches] Make warnings for relative URIs with no base URI configurable

[Chris Burdess]

Chris Burdess wrote:
> > > > This patch makes warnings for relative URIs with no base URI
> > > > configurable by a boolean system property
> > > > 'gnu.xml.aelfred2.XmlParser.uriWarnings'. The default is not to
> > > > emit such warnings, in order to correct behaviour in Debian
> > > > checkstyle and other applications.
> > > >
> > > > 2005-01-18  Chris Burdess  <address@hidden>
> > > >
> > > >     * gnu/xml/aelfred2/XmlParser.java: Added uriWarnings class
> > > > field to configure warnings for relative URIs with no base URI.
> >
> > It would be nice if the warnings were turned on by default and only
> > turned off when done explicitly (the warning could add a hint how to
> > turn the warnings off). The idea being that hopefully the code will 
> > get
> > fixed instead of these warnings being turned off.
> >
> > Also please look at this patch that does some more validity checking:
> > http://lists.gnu.org/archive/html/classpathx-xml/2004-12/msg00027.html
> >
> > You are trying to catch SecurityExceptions trying to get the system
> > properties (which is a good idea if the code can be executed from an
> > untrusted context). It seems this is a good place to use a
> > GetSystemPropertyAction to access these SystemProperties since we can
> > assume this is trusted code.
>
> Please review the following patch which addresses both these issues.

Since other work has been carried out on Ælfred2 in the meantime, here 
is an updated version of the patch which should apply cleanly against 
CVS HEAD.
--
Chris Burdess

patch
Description: Binary data