Re: [cp-patches] PING: java.util.Locale getISO* patch

[Michael Koch]

On Wed, Feb 16, 2005 at 01:30:10AM +0000, Andrew John Hughes wrote:
> On Wed, 2005-01-05 at 16:19 +0000, Andrew John Hughes wrote:
> > Hi all,
> > 
> >     Attached is a patch to change the getISOLanguages() and 
> > getISOCountries()
> > methods to retrieving the data dynamically from the 
> > gnu.java.locale.LocaleInformation
> > source, rather than relying on a static set.
> > 
> >     * java/util/Locale.java
> >     Added two new String[] arrays for caching.
> >     getLocale(String): documentation
> >     getLocale(String, String): documentation
> >     getLocale(String, String, String): documentation
> >     getISOCountries(): now calls getISOStrings() and caches result
> >     getISOLanguages(): now calls getISOStrings() and caches result
> >     getISOStrings(String): pulls all two-letter keys from the specified 
> > hashtable
> >     in our locale information.
> > 
> > _______________________________________________
> > Classpath-patches mailing list
> > address@hidden
> > http://lists.gnu.org/mailman/listinfo/classpath-patches
> 
> I posted this patch over a month ago, and it completely slipped my mind
> until now (thanks to Paul Jenner for reminding me).  Does anyone have
> any thoughts on this?  I'm not sure of whether this is right to do, so
> I'd like some comments as to whether to commit or not.

The patch is very good. Please commit.


Michael