Re: [cp-patches] Calendar/Date/TimeZone/Text merging

[Mark Wielaard]

Hi,

On Thu, 2005-02-17 at 10:29 +0100, Mark Wielaard wrote:
> Just to make people aware that I am working on this. I collected some of
> the important Calendar, Date, TimeZone and java.text fixes that have
> gone into GNU Classpath in the last couple of months but not into libgcj
> yet. We discussed most of these on the main libgcj mailinglist.
> 
> With this applied there are a lot of new Mauve tests that now pass.
> Unfortunately there are a few regressions that need investigation which
> I have not done yet. I will try to make time for this tonight, but help
> is appreciated. Attached are the ChangeLog entries, the actual patch and
> the relevant part of the diff between the mauve runs.

Some progress. Mostly thanks to Sven's help on irc.
When adding the following two fixes we get a lot less mauve failures:

2005-02-17  Mark Wielaard  <address@hidden>

        * java/util/SimpleTimeZone.java (checkRule): Throw
        IllegalArgumentException when month out of range.

2005-02-17  Sven de Marothy  <address@hidden>

        * java/util/GregorianCalendar.java,
        (add): Don't set fields directly anymore. Use set()

We have no regressions (and a lot of fixes) in the (Gregorian)Calendar
mauve tests now. The remaining new failures (not all regressions!) are
in:

gnu.testlet.java.text.SimpleDateFormat.regress
gnu.testlet.java.text.SimpleDateFormat.parse
gnu.testlet.java.text.SimpleDateFormat.Localization
gnu.testlet.java.text.SimpleDateFormat.applyLocalizedPattern
gnu.testlet.java.text.SimpleDateFormat.constructors
gnu.testlet.java.util.SimpleTimeZone.check12
gnu.testlet.java.util.SimpleTimeZone.check14
gnu.testlet.java.util.SimpleTimeZone.getOffset

The actual regressions are:

-PASS: gnu.testlet.java.text.SimpleDateFormat.regress: EST (number 1)
+FAIL: gnu.testlet.java.text.SimpleDateFormat.regress: EST (number 1)

-PASS: gnu.testlet.java.text.SimpleDateFormat.constructors:
SimpleDateFormat(String, DateFormatSymbols) (number 4)
+FAIL: gnu.testlet.java.text.SimpleDateFormat.constructors:
SimpleDateFormat(String, DateFormatSymbols) (number 4)

-PASS: gnu.testlet.java.util.SimpleTimeZone.check12 (number 4)
+FAIL: gnu.testlet.java.util.SimpleTimeZone.check12 (number 4)
-PASS: gnu.testlet.java.util.SimpleTimeZone.check12 (number 8)
+FAIL: gnu.testlet.java.util.SimpleTimeZone.check12 (number 8)
-PASS: gnu.testlet.java.util.SimpleTimeZone.check12 (number 12)
+FAIL: gnu.testlet.java.util.SimpleTimeZone.check12 (number 12)
-PASS: gnu.testlet.java.util.SimpleTimeZone.check12 (number 16)
+FAIL: gnu.testlet.java.util.SimpleTimeZone.check12 (number 16)
-PASS: gnu.testlet.java.util.SimpleTimeZone.check12 (number 20)
+FAIL: gnu.testlet.java.util.SimpleTimeZone.check12 (number 20)
-PASS: gnu.testlet.java.util.SimpleTimeZone.check14 (number 10)
-PASS: gnu.testlet.java.util.SimpleTimeZone.check14 (number 11)
-PASS: gnu.testlet.java.util.SimpleTimeZone.check14 (number 12)
+FAIL: gnu.testlet.java.util.SimpleTimeZone.check14 (number 10)
+FAIL: gnu.testlet.java.util.SimpleTimeZone.check14 (number 11)
+FAIL: gnu.testlet.java.util.SimpleTimeZone.check14 (number 12)

-PASS: gnu.testlet.java.util.SimpleTimeZone.getOffset: (int, int, int,
int, int, int) (number 4)
+FAIL: gnu.testlet.java.util.SimpleTimeZone.getOffset: (int, int, int,
int, int, int) (number 4)

Note that there are also around 200 new tests that now succeed!

Cheers,

Mark

signature.asc
Description: This is a digitally signed message part