Re: [cp-patches] Small Throwable patch

[Michael Koch]

On Fri, Feb 18, 2005 at 09:05:29PM -0600, Archie Cobbs wrote:
> I'm planning to commit this patch. The reason for it is that the
> logic of initCause() is unnecessary in the constructor, and represents
> unnecessary overhead which we pay for every time a chained exception
> is created. The effect is especially exacerbated when the constructor
> invocation is inlined at every instantiation site, bloating code size.
> 
> Note that initCause() is not final, so a subclass could override it;
> however the constructor does not specify that it calls initCause() to
> initialize the cause so this doesn't change any specified behavior.
> 
> 2005-02-19  Archie Cobbs  <address@hidden>
>  
>      * java/lang/Throwable.java: simplify initializing cause in constructor

I think it would be best to test the behavior of latest SUN JDK and then
act on this. If it calles initCause() we need to do this too. If not we
should not too.


Michael