[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [cp-patches] Fixing the incorrect work of javax.swing.Timer.getIniti
From: |
Mark Wielaard |
Subject: |
Re: [cp-patches] Fixing the incorrect work of javax.swing.Timer.getInitialDelay() |
Date: |
Thu, 24 Feb 2005 13:38:24 +0100 |
Hi Audrius,
On Thu, 2005-02-24 at 12:28 +0100, Meskauskas Audrius wrote:
> From the code is seen that the initial delay field is not initialised in
> constructor, leaving it with the default value 0.
>
> Both problems can be fixed by setting this field to the constructor
> parameter value.
Thanks for catching this. And thanks for adding documentation.
The fix looks correct.
Could you add a ChangeLog entry in the message to classpath-patches and
commit both the changed file and the ChangeLog message at the same time
(that makes it easier to see what changes belong together in the cvs log
later.)
> delay = d;
> + initialDelay = d;
>
> if (listener != null)
> addActionListener(listener);
Note the identation. delay and initialDelay should start on the same
line.
Please commit this with the identation fixlet.
Thanks,
Mark
signature.asc
Description: This is a digitally signed message part