Re: [cp-patches] wrapping-capable JList

[Michael Koch]

On Sat, Feb 26, 2005 at 11:52:07PM +0100, Roman Kennke wrote:
> Hi there again,
> 
> I again improved the JList implementation so that is now aware of the
> property layoutOrientation. To get a quick view of how a wrapping list
> may look like please refer to the screenshot at (the left one):
> 
> http://java.sun.com/docs/books/tutorial/uiswing/components/list.html
> 
> (sorry for referring to java.sun.com, I am tired and don't have the
> nerves to make a screenshot myself...)
> 
> some quick tests show that it works for some trivial apps, don't know
> about more complex stuff. I will do some tests tomorrow as well as add a
> demo to Demo.java.
> 
> The patch is attached, please review and approve it for commit.

The patch is fine in general but the your formatting of the if
statements are crucial to read.

if (...) {
  // Do something.
} else {
  // Do somthing different.
}

should look like this

if (...)
  {
    // Do something.
  }
else
  {
    // Do something differnt.
  }

With this formatting change its okay. Please commit.
That is really good work.


THANKS,

Michael