Re: [cp-patches] scrollable JList

[Michael Koch]

On Mon, Feb 28, 2005 at 11:27:30AM +0100, Roman Kennke wrote:
> Hi,
> 
> please review the attached patch that improves the behaviour of JList
> within a scrolling container, especially with layoutOrientation set to
> JList.HORIZONTAL_WRAP or VERTICAL_WRAP. Is the ChangeLog entry ok?
> 
> 2005-02-27  Roman Kennke  <address@hidden>
> 
>       * javax/swing/JList.java
>       (getPreferredScrollableViewportSize):
>       previous implementation was merely guessing the size,
>       now it respects layoutOrientation, visibleRowCount
>       and preferredSize
>       (getScrollableTracksViewportHeight):
>       reimplemented to respect layoutOrientation, visibleRowCount
>       and preferred size
>       (getScrollableTracksViewportWidth):
>       reimplemented to respect layoutOrientation, visibleRowCount
>       and preferred size
>       * javax/swing/plaf/basic/BasicListUI.java
>       (getPreferredSize):
>       improved calculation of preferredSize when JList is
>       set to HORIZONTAL_WRAP or VERTICAL_WRAP.
>       (getCellBounds):
>       previous implementation assumed a layoutOrientation of
>       JList.VERTICAL, now also ok with JList.HORIZONTAL_WRAP and
>       JList.VERTICAL_WRAP

Sentences start with upercase letters, even in english language. :-)

The patch itself is very very fine. Please commit.


Michael
--
Java Trap: http://www.gnu.org/philosophy/java-trap.html