Re: [cp-patches] FYI: actioncommand fixes

[Mark Wielaard]

Hi,

On Fri, 2005-07-15 at 10:59 +0200, Roman Kennke wrote:
> I have applied all patches and still breaks my app. I get an 
> actionCommand of null where "" is expected at the very least. If it 
> still matters (I committed a fix in the meantime) I could try to boil 
> this case down to a simple testcase.

Yes please.

> This makes perfect sense. Still it does not work, but it seems that my 
> problems come from both actionCommand and text beeing null, and the 
> button should return something non-null nevertheless. I already 
> committed a patch for that, I hope I did it right. I really should put 
> together a testcase for this actionCommand thingy. I (and others) 
> changed the behaviour of actionCommand handling several times and it 
> seems that we never got it right. :-/

Here are the differences between the mauve tests for actionCommands
between 0.16 and the soon to be finalized 0.17. As you can see the test
score overall improved a lot. But some PASSes did turn into FAILs :{

-FAIL: gnu.testlet.javax.swing.JToggleButton.click: getActionCommand (number 1)
+PASS: gnu.testlet.javax.swing.JToggleButton.click: getActionCommand (number 1)
-FAIL: gnu.testlet.javax.swing.JToggleButton.getActionCommand (number 1)
-FAIL: gnu.testlet.javax.swing.JToggleButton.getActionCommand (number 2)
+PASS: gnu.testlet.javax.swing.JToggleButton.getActionCommand (number 1)
+PASS: gnu.testlet.javax.swing.JToggleButton.getActionCommand (number 2)
 FAIL: gnu.testlet.javax.swing.JToggleButton.getActionCommand (number 3)
 PASS: gnu.testlet.javax.swing.JToggleButton.getActionCommand (number 4)
 PASS: gnu.testlet.javax.swing.JToggleButton.getActionCommand (number 5)
 PASS: gnu.testlet.javax.swing.JToggleButton.getActionCommand (number 6)
-FAIL: gnu.testlet.javax.swing.JToggleButton.getActionCommand (number 7)
+PASS: gnu.testlet.javax.swing.JToggleButton.getActionCommand (number 7)
 PASS: gnu.testlet.javax.swing.JButton.getActionCommand (number 1)
-FAIL: gnu.testlet.javax.swing.JButton.getActionCommand (number 2)
+PASS: gnu.testlet.javax.swing.JButton.getActionCommand (number 2)
 FAIL: gnu.testlet.javax.swing.JButton.getActionCommand (number 3)
 PASS: gnu.testlet.javax.swing.JButton.getActionCommand (number 4)
 PASS: gnu.testlet.javax.swing.JButton.getActionCommand (number 5)
 PASS: gnu.testlet.javax.swing.JButton.getActionCommand (number 6)
-FAIL: gnu.testlet.javax.swing.JButton.getActionCommand (number 7)
-FAIL: gnu.testlet.javax.swing.JCheckBox.getActionCommand (number 1)
-FAIL: gnu.testlet.javax.swing.JCheckBox.getActionCommand (number 2)
+PASS: gnu.testlet.javax.swing.JButton.getActionCommand (number 7)
+PASS: gnu.testlet.javax.swing.JCheckBox.getActionCommand (number 1)
+PASS: gnu.testlet.javax.swing.JCheckBox.getActionCommand (number 2)
 FAIL: gnu.testlet.javax.swing.JCheckBox.getActionCommand (number 3)
 PASS: gnu.testlet.javax.swing.JCheckBox.getActionCommand (number 4)
 PASS: gnu.testlet.javax.swing.JCheckBox.getActionCommand (number 5)
 PASS: gnu.testlet.javax.swing.JCheckBox.getActionCommand (number 6)
-FAIL: gnu.testlet.javax.swing.JCheckBox.getActionCommand (number 7)
-FAIL: gnu.testlet.javax.swing.JCheckBoxMenuItem.getActionCommand (number 1)
-FAIL: gnu.testlet.javax.swing.JCheckBoxMenuItem.getActionCommand (number 2)
-PASS: gnu.testlet.javax.swing.JCheckBoxMenuItem.getActionCommand (number 3)
+PASS: gnu.testlet.javax.swing.JCheckBox.getActionCommand (number 7)
+PASS: gnu.testlet.javax.swing.JCheckBoxMenuItem.getActionCommand (number 1)
+PASS: gnu.testlet.javax.swing.JCheckBoxMenuItem.getActionCommand (number 2)
+FAIL: gnu.testlet.javax.swing.JCheckBoxMenuItem.getActionCommand (number 3)
 PASS: gnu.testlet.javax.swing.JCheckBoxMenuItem.getActionCommand (number 4)
 PASS: gnu.testlet.javax.swing.JCheckBoxMenuItem.getActionCommand (number 5)
 PASS: gnu.testlet.javax.swing.JCheckBoxMenuItem.getActionCommand (number 6)
-FAIL: gnu.testlet.javax.swing.JCheckBoxMenuItem.getActionCommand (number 7)
-FAIL: gnu.testlet.javax.swing.JMenu.getActionCommand (number 1)
-FAIL: gnu.testlet.javax.swing.JMenu.getActionCommand (number 2)
-PASS: gnu.testlet.javax.swing.JMenu.getActionCommand (number 3)
+PASS: gnu.testlet.javax.swing.JCheckBoxMenuItem.getActionCommand (number 7)
+PASS: gnu.testlet.javax.swing.JMenu.getActionCommand (number 1)
+PASS: gnu.testlet.javax.swing.JMenu.getActionCommand (number 2)
+FAIL: gnu.testlet.javax.swing.JMenu.getActionCommand (number 3)
 PASS: gnu.testlet.javax.swing.JMenu.getActionCommand (number 4)
 PASS: gnu.testlet.javax.swing.JMenu.getActionCommand (number 5)
 PASS: gnu.testlet.javax.swing.JMenu.getActionCommand (number 6)
-FAIL: gnu.testlet.javax.swing.JMenu.getActionCommand (number 7)
-FAIL: gnu.testlet.javax.swing.JMenuItem.getActionCommand (number 1)
-FAIL: gnu.testlet.javax.swing.JMenuItem.getActionCommand (number 2)
-PASS: gnu.testlet.javax.swing.JMenuItem.getActionCommand (number 3)
+PASS: gnu.testlet.javax.swing.JMenu.getActionCommand (number 7)
+PASS: gnu.testlet.javax.swing.JMenuItem.getActionCommand (number 1)
+PASS: gnu.testlet.javax.swing.JMenuItem.getActionCommand (number 2)
+FAIL: gnu.testlet.javax.swing.JMenuItem.getActionCommand (number 3)
 PASS: gnu.testlet.javax.swing.JMenuItem.getActionCommand (number 4)
 PASS: gnu.testlet.javax.swing.JMenuItem.getActionCommand (number 5)
 PASS: gnu.testlet.javax.swing.JMenuItem.getActionCommand (number 6)
-FAIL: gnu.testlet.javax.swing.JMenuItem.getActionCommand (number 7)
-FAIL: gnu.testlet.javax.swing.JRadioButton.getActionCommand (number 1)
-FAIL: gnu.testlet.javax.swing.JRadioButton.getActionCommand (number 2)
+PASS: gnu.testlet.javax.swing.JMenuItem.getActionCommand (number 7)
+PASS: gnu.testlet.javax.swing.JRadioButton.getActionCommand (number 1)
+PASS: gnu.testlet.javax.swing.JRadioButton.getActionCommand (number 2)
 FAIL: gnu.testlet.javax.swing.JRadioButton.getActionCommand (number 3)
 PASS: gnu.testlet.javax.swing.JRadioButton.getActionCommand (number 4)
 PASS: gnu.testlet.javax.swing.JRadioButton.getActionCommand (number 5)
 PASS: gnu.testlet.javax.swing.JRadioButton.getActionCommand (number 6)
-FAIL: gnu.testlet.javax.swing.JRadioButton.getActionCommand (number 7)
-FAIL: gnu.testlet.javax.swing.JRadioButtonMenuItem.getActionCommand (number 1)
-FAIL: gnu.testlet.javax.swing.JRadioButtonMenuItem.getActionCommand (number 2)
-PASS: gnu.testlet.javax.swing.JRadioButtonMenuItem.getActionCommand (number 3)
+PASS: gnu.testlet.javax.swing.JRadioButton.getActionCommand (number 7)
+PASS: gnu.testlet.javax.swing.JRadioButtonMenuItem.getActionCommand (number 1)
+PASS: gnu.testlet.javax.swing.JRadioButtonMenuItem.getActionCommand (number 2)
+FAIL: gnu.testlet.javax.swing.JRadioButtonMenuItem.getActionCommand (number 3)
 PASS: gnu.testlet.javax.swing.JRadioButtonMenuItem.getActionCommand (number 4)
 PASS: gnu.testlet.javax.swing.JRadioButtonMenuItem.getActionCommand (number 5)
 PASS: gnu.testlet.javax.swing.JRadioButtonMenuItem.getActionCommand (number 6)
-FAIL: gnu.testlet.javax.swing.JRadioButtonMenuItem.getActionCommand (number 7)
+PASS: gnu.testlet.javax.swing.JRadioButtonMenuItem.getActionCommand (number 7)

signature.asc
Description: This is a digitally signed message part