Re: [cp-patches] FYI: Another icons fixlet

[Mark Wielaard]

Hi,

On Fri, 2005-07-15 at 10:08 -0600, Tom Tromey wrote:
> >>>>> "Mark" == Mark Wielaard <address@hidden> writes:
> 
> Mark> The icons weren't actually included in the distribution since our
> Mark> dist-hook removes everything from standard.omit at the last moment.
> 
> Why would we do that in dist-hook?
> 
> Also, why are the icons in the source directories and not somewhere
> under resource/?  Or to put it another way, why do we have resource
> as a separate directory?

Both are historic. The gtk plaf was written by Brian before we had a
real working swing.plaf implementation. It partly didn't compile so we
put it in standard.omit. If it compiles now and actually works we should
remove the whole line from standard.omit.

I believe removing anything from standard.omit in the dist-hook is just
wrong. And I will remove that part. Since the build scripts will take
care of it anyway, so there is no harm in distributing.

It is probably also better to have all resources under resource/ to make
the build easier. I haven't investigated that yet though.

Cheers,

Mark

signature.asc
Description: This is a digitally signed message part