Re: [cp-patches] FYI: Some fixes and optimizations for Container

[Roman Kennke]

Hi,

> > -/* AWTUtilities.java -- Common utility methods for AWT and Swing.
> > -   Copyright (C) 2005  Free Software Foundation, Inc.
> > +/* Copyright (C) 2004 Free Software Foundation
>
>
> Don't do that.

sorry, I simply copied over the file (from our repo). I will take more 
care in the future. I'll fix this tomorrow.

> > -Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
> > -02110-1301 USA.
> > +Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
> > +02111-1307 USA.
>
>
> Please keep the new address in place everywhere.

See above.

> > +  public static Rectangle calculateInsetArea(Rectangle base, Insets
> > insets,
> > +
> > Rectangle ret)
>
>
> This looks strange, did you forget a return here?
> There are a couple of similar things like this in the patch.

Now I was confused. I thought you meant a missing return statement which 
would have been rejected by the compiler. I see you mean the bad 
formatting. I will go over this file and fix everything tomorrow. Sorry 
for this crap.

/Roman