Re: [PATCH] Field position attribute handling

[Dalibor Topic]

Michael Koch wrote:
> On Tue, Nov 18, 2003 at 08:30:44PM +0100, Dalibor Topic wrote:
>
> > 2003-11-18 Guilhem Lavaux <address@hidden>
> >
> >    * java/text/FieldPosition.java (field_attribute): New field.
> >    (FieldPosition (Format.Field), FieldPosition(Format.Field, int),
> >    getFieldAttribute) New methods.
> >
> > 2003-11-18 Dalibor Topic <address@hidden>
> >
> >    * java/text/FieldPosition.java (equals) : Adapted to handle
> >    field_attribute. Added fast-circuit check for comparison to self.
> >    Replaced use of instanceof by getClass to fix symmetry for derived
> >    types.
> >    (toString) Adapted to handle field_attribute. Improved readability.
> >    (hashCode) New method.
>
>
> There are some missing ':'. The rule is:
>
>         (methodname): description of change.

thnaks for catching that one. how about:

2003-11-18 Guilhem Lavaux <address@hidden>

    * java/text/FieldPosition.java (field_attribute): New field.
    (FieldPosition (Format.Field), FieldPosition(Format.Field, int),
    getFieldAttribute): New methods.

2003-11-18 Dalibor Topic <address@hidden>

    * java/text/FieldPosition.java (equals): Adapted to handle
    field_attribute. Added fast-circuit check for comparison to self.
    Replaced use of instanceof by getClass to fix symmetry for derived
    types.
    (toString): Adapted to handle field_attribute. Improved readability.
    (hashCode): New method.

cheers,
dalibor topic