[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH] Fix for Hashtable contains blowing up the stack

From: Mark Wielaard
Subject: RE: [PATCH] Fix for Hashtable contains blowing up the stack
Date: Sat, 22 Nov 2003 13:51:59 +0100


On Sat, 2003-11-22 at 13:06, Jeroen Frijters wrote:
> The fix is actually incorrect. containsValue() should call contains()
> because containsValue() is a new method (since 1.2) and contains()
> exists since 1.0. Older code may have overridden contains() and this
> should work with newer code that calls containsValue().

Urgh. Yes, you are right. Wrote an additional test case for this: (it currently fails).

> As I've argued before, in cases such as these (multiple virtual methods
> that do the same thing), we must use the same delegation as the Sun
> implementation to be compatible.

Problem is that this is not always easy to know.
So we depend on bug reports and then have to write a Mauve test if we
think that following such behavior is beneficial. But the "newer calls
older" is a guideline that will mostly work (I hope).

BTW. People might want the read what Jeroen wrote earlier about it:
His blog entires (and the people who comment on it) are very nice BTW.
I am always a bit sad when there is a week without a new entry.



Attachment: signature.asc
Description: This is a digitally signed message part

reply via email to

[Prev in Thread] Current Thread [Next in Thread]