classpath
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] fix to JLayeredPane


From: Michael Koch
Subject: Re: [patch] fix to JLayeredPane
Date: Fri, 9 Jan 2004 08:55:43 +0100
User-agent: Mutt/1.3.28i

On Thu, Jan 08, 2004 at 10:04:25PM -0500, graydon hoare wrote:
> hi,
> 
> this patch adapts JLayeredPane to the changes address@hidden recently 
> made to Container; notably he discovered that the drawing order in 
> container does not match sun's, so reversed it. re-reading the javadocs, 
> I see that I did not implement JLayeredPane correctly, and that its 
> documentation makes more sense considering this "correct" order he 
> discovered. so I've rewritten it to work in that order.
> 
> ok to apply?
> 
> (and before you ask, yes, the mauve tests are confirmed to work both 
> ways -- hooray for the "layer" abstraction -- but I'll be extending them 
> to check the underlying mapping too).
> 
> -graydon
> 
> 2004-01-08  Graydon Hoare  <address@hidden>
> 
>       * javax/swing/JLayeredPane.java: Rewrite to accomodate
>       address@hidden's recent inverse ordering of Container elements.

Hi Graydon,


You added "<p> ... </p>" in several places where they are not needed
(when there is only one paragraph in the method documentation).

Just my 2 cents.


Michael




reply via email to

[Prev in Thread] Current Thread [Next in Thread]