classpath
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

O_SYNC/O_FSYNC fix


From: Archie Cobbs
Subject: O_SYNC/O_FSYNC fix
Date: Tue, 27 Jan 2004 14:20:57 -0600 (CST)

Hi Michael,

This is regarding the Classpath patch to fix the O_SYNC/O_FSYNC problem
with FreeBSD I reported a while ago.

I am currently unable to build from CVS because of auto* confusion
and version mismatches that I don't have time to figure out right now.

However I've tried classpath 0.07 with the patch applied (ie, this one:)

    
http://savannah.gnu.org/cgi-bin/viewcvs/classpath/classpath/native/target/generic/target_generic_file.h.diff?r1=1.11&r2=1.12&diff_format=u

and it still does not work. The problem seems to be that when
target_generic_file.h is included, <fcntl.h> has not yet been
included. So neither of O_SYNC or O_FSYNC is defined yet, and
the result is the same (O_SYNC is chosen which is incorrect).

Not sure what the "right" fix is but the patch below does work.

Thanks,
-Archie

__________________________________________________________________________
Archie Cobbs     *    Halloo Communications    *     http://www.halloo.com

--- classpath-0.07/native/jni/java-io/FileDescriptor.c.orig     Wed Jul 30 
05:11:34 2003
+++ classpath-0.07/native/jni/java-io/FileDescriptor.c  Tue Jan 27 14:16:45 2004
@@ -49,6 +49,7 @@
 #include <config.h>
 
 #include <stdlib.h>
+#include <fcntl.h>
 
 /* FIXME: Need to make configure set these for us */
 /* #define HAVE_SYS_IOCTL_H */




reply via email to

[Prev in Thread] Current Thread [Next in Thread]