Re: AWT regression?

[Thomas Fitzsimmons]

On Thu, 2004-04-29 at 09:42, Grzegorz B. Prokopski wrote:
> On Wed, 2004-04-28 at 12:46, Thomas Fitzsimmons wrote:
> > On Sat, 2004-04-24 at 18:52, Grzegorz B. Prokopski wrote:
> > > Hi all,
> > > 
> > > We've just imported fresh GNU CP as of Fri Apr 23 and running SymbolTest
> > > program, that previously worked nicely, as documented ex. at
> > > http://www.sablevm.org/screenshots , now gives this:
> > > 
> > > $ ~/work/bin/java-sablevm SymbolTest 
> > > (:19347): Gtk-CRITICAL **: file gtkwidget.c: line 4248
> > >   (gtk_widget_modify_fg): assertion `GTK_IS_WIDGET (widget)' failed
> > > (:19347): Gtk-CRITICAL **: file gtkwidget.c: line 4248
> > >   (gtk_widget_modify_fg): assertion `GTK_IS_WIDGET (widget)' failed
> > > (:19347): Gtk-CRITICAL **: file gtkwidget.c: line 4248
> > >   (gtk_widget_modify_fg): assertion `GTK_IS_WIDGET (widget)' failed
> > >  java.lang.NullPointerException
> > >     at java.applet.Applet.getDimensions (Applet.java:469)
> > >     at java.applet.Applet.preferredSize (Applet.java:486)
> > >     at java.awt.Container.getPreferredSize (Container.java:576)
> > >     at java.awt.BorderLayout.calcCompSize (BorderLayout.java:647)
> > >     at java.awt.BorderLayout.calcSize (BorderLayout.java:692)
> > >     at java.awt.BorderLayout.preferredLayoutSize (BorderLayout.java:454)
> > >     at java.awt.Container.preferredSize (Container.java:589)
> > >     at java.awt.Container.getPreferredSize (Container.java:576)
> > >     at java.awt.Window.pack (Window.java:206)
> > >     at SymbolTest.main (SymbolTest.java:100)
> > >     at java.lang.VirtualMachine.invokeMain (VirtualMachine.java)
> > >     at java.lang.VirtualMachine.main (VirtualMachine.java:88)
> > > 
> > 
> > I recently changed size reporting in Applet.java.  I made applets report
> > their preferred size as the width and height attributes given in the
> > applet tag.  However, the current code assumes that an applet stub is
> > present that can be queried for these attributes.  The NPE you're seeing
> > is likely caused by the stub not having been set.
> > 
> > The attached patch should fix the problem, though I haven't tested it. 
> > Can you try it out?
> 
> Hi Thomas,
> 
> I got a report (had no time to do it myself :-( ) that your patch
> actually fixed the problem.  I guess it should go into GNU CP CVS ASAP
> and 0.09 release too.
> 

OK, patch checked in.  I think the fix will make it into 0.09.  Thanks
for the report,

Tom