Re: [cp-patches] FYI: fix warnings in NIO JNI

[Casey Marshall]

Hm. Ok. 'mincore' is declared to take an 'unsigned char *' on GNU,  
but a 'char *' on Darwin. pinskia suggested on IRC that casting the  
argument to 'void *' would be a good enough workaround, so I'm  
checking this little change in.

2005-07-30  Casey Marshall  <address@hidden>

    * native/jni/java-nio/java_nio_MappedByteBuffer.c
    (Java_java_nio_MappedByteBufferImpl_isLoadedImpl): cast argument 3
    to 'mincore' to 'void *' to avoid warnings on GNU.

On Jul 30, 2005, at 1:39 PM, Casey Marshall wrote:

> This patch fixes the warnings I introduced into the java-nio JNI  
> library with my recent changes, and fixes the crash I was seeing on  
> OS X 10.4.
>
> 2005-07-30  Casey Marshall  <address@hidden>
>
>     * native/jni/java-nio/gnu_java_nio_channels_FileChannelImpl.c
>     (Java_gnu_java_nio_channels_FileChannelImpl_mapImpl):
>     eliminate various compiler warnings; mark 'buffer' as 'volatile;'
>     throw an exception if we can't get a constructor method ID.
>     * native/jni/java-nio/java_nio_MappedByteBufferImpl.c:
>     include 'stdlib.h.'
>     (get_raw_values): eliminate compiler warnings.
>     (Java_java_nio_MappedByteBufferImpl_isLoadedImpl): likewise.
>     * native/jni/java-nio/java_nio_VMDirectByteBuffer.c
>      
> (Java_java_nio_VMDirectByteBuffer_put__Lgnu_classpath_RawData_2I_3BII) 
> :
>     eliminate compiler warning.
>
>
> <nio.patch.txt>
> _______________________________________________
> Classpath-patches mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/classpath-patches

nio-mincore-gnu-borkenness.patch.txt
Description: Text document