RE: Patches to java.util.zip by Christian Schlichtherle

[Mark Wielaard]

Hi,

On Wed, 2005-08-31 at 12:06 +0200, Jeroen Frijters wrote:
> Christian Schlichtherle wrote:
> > the changes from int to long are required as to the ZIP file format
> > specification available online from PKZIP Inc.
> > 
> > The specification says that all integers are 4 byte unsigned integers.
> > Java's int type is 4 byte signed, thus the type long is 
> > required to hold a ZIP file integer. You can find this in other
> > popular Java based ZIP file implementations as well (Apache ant, the
> > JDK, etc.).
> 
> Thanks for taking the time to explain this. We obviously should take in
> these fixes.

Yes, if someone can make a little testcase where we fail now and show
how we are not properly converting the signed/unsigned ints at the
moment that would be appreciated. Note that at the moment all public
methods take and return longs already, we only store it as int
internally and try treat it as unsigned already. It might be that we
need to internally store everything in an long and not just treat the
signed ints as unsigned ints as we do now in the code, but the patch
contained so many unrelated changes that it was hard to make out which
changes were explicitly for this issue. So if someone could extract
those parts of the patch that would help a lot.

Thanks,

Mark

signature.asc
Description: This is a digitally signed message part