Re: FYI: Patch: java.awt.image.PixelGrabber

[Mark Wielaard]

Hi,

On Fri, 2003-12-26 at 19:04, Michael Koch wrote:
> On Fri, Dec 26, 2003 at 06:40:29PM +0100, Mark Wielaard wrote:
> > 
> > But the actual diff only lists some added asserts.
> > Could you double check this patch?
> 
> Thx for catching this. I relied too much on the cvs changelog of libgcj.
> The patch was already merged, without the assert. The reason for this is
> not documentated in the archive. At least I dont found it.
> 
> Should I just rework the changelog entry or what is your preferred
> solution for this ?

Saw that you already backed it out since the asserts didn't work nicely
with the default jikes compile. Just keep the ChangeLog entries as they
are. Changing the ChangeLog file in the past always feels like changing
history. And it is just a double entry now.

Lets keep asserts out of Classpath sources for now since by default not
all compilers support it. But I do like to see them in the future if we
can actually use them more then in one or two spots.

Cheers,

Mark