commit-classpath
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[commit-cp] [task #4221] Better handling of the CORBA exceptions


From: Audrius Meškauskas
Subject: [commit-cp] [task #4221] Better handling of the CORBA exceptions
Date: Fri, 3 Jun 2005 11:38:07 +0000
User-agent: Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1)

URL:
  <http://savannah.gnu.org/task/?func=detailitem&item_id=4221>

                 Summary: Better handling of the CORBA exceptions
                 Project: classpath
            Submitted by: audriusa
            Submitted on: Fri 06/03/2005 at 11:38
                Category: CORBA
         Should Start On: Fri 06/03/2005 at 00:00
   Should be Finished on: Fri 06/03/2005 at 00:00
                Priority: 5 - Normal
                  Status: None
                 Privacy: Private
        Percent Complete: 0%
             Assigned to: None
             Open/Closed: Open
                  Effort: 0.00

    _______________________________________________________

Details:

In the CORBA code I see this:

 [...]

    catch (Exception ex)
      {
        throw new MARSHAL(ex + ":" + ex.getMessage());
      }

This is weird since Throwable.toString() (i.e. the default) includes
getMessage.  I think it would be a bit better to just use getMessage here and
add a package-private constructor to allow exception chaining:

   throw new MARSHAL(ex.getMessage(), ex);

This good idea was suggested by Tom Trommey.








    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/task/?func=detailitem&item_id=4221>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]