Re: [Patch] configure: Also check C++11 (flags) for ${build} compiler not only for ${host}

[Tobias Burnus]

On 8/20/20 7:12 PM, Joseph Myers wrote:

> It appears you're requiring _FOR_BUILD here and considering other suffixes
> invalid, which would prevent any other use, e.g. _FOR_TARGET.

Actually, the main reason I required _FOR_BUILD
was that I couldn't find m4_ifnblank and then gave up ...
Now having finally found it, I removed the $4 arg check and
the later _FOR_BUILD use.

> >     m4_if([$2], [], [dnl
> >       AC_CACHE_CHECK(whether $CXX supports C++$1 features by default,
> > -               ax_cv_cxx_compile_cxx$1,
> > +               ax_cv_cxx_compile_cxx$1$4,
> >         
> > [AC_COMPILE_IFELSE([AC_LANG_SOURCE([_AX_CXX_COMPILE_STDCXX_testbody_$1])],
> >           [ax_cv_cxx_compile_cxx$1=yes],
> >           [ax_cv_cxx_compile_cxx$1=no])])
> I think this needs to update the variable name in the assignments of the
> result of the check, and then in the subsequent check for whether to set
> ac_success=yes, not just in the second argument to AC_CACHE_CHECK.

I know I would miss one of those ...

Thanks for the first review; new version attached.

Tobias

-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany
Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander 
Walter

config-cxx11-v2.diff
Description: Text Data