cons-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: building files with nasm (#2)


From: Steven Knight
Subject: Re: building files with nasm (#2)
Date: Fri, 2 Nov 2001 11:42:25 -0600 (CST)

> but .. this doesn't work!
> 
> I grabbed latest cons from cvs, and debugged it .. I traced it to sub
> _Object on line 1188, the $suffix is empty when it tries to find out how
> to build a .o from a .nasm. I'm attaching a patch I applied to hack to
> work .. it would be great if a cons guru could lookup what's borked and
> tell me.

Yikes!  The suffix logic to decide between WIN32 and non-WIN32 is
completely backwards.  The intent is that Cons is supposed to know that
a WIN32 system can only have three-character suffixes, but an errant "!"
is making it enforce the three-character limit on *non*-WIN32 systems.
Diff appended below.

        --SK



RCS file: /home/cvs/cons/src/cons.pl,v
retrieving revision 1.172
diff -c -r1.172 cons.pl
*** src/cons.pl 2001/09/21 14:38:53     1.172
--- src/cons.pl 2001/11/02 17:09:35
***************
*** 3037,3043 ****
  # Return the suffix of the file, for up to a 3 character
  # suffix. Anything less returns nothing.
  sub suffix {
!   if (! $main::_WIN32) {
      $_[0]->{entry} =~ /\.[^\.\/]{0,3}$/;
      $&
    } else {
--- 3037,3043 ----
  # Return the suffix of the file, for up to a 3 character
  # suffix. Anything less returns nothing.
  sub suffix {
!   if ($main::_WIN32) {
      $_[0]->{entry} =~ /\.[^\.\/]{0,3}$/;
      $&
    } else {






reply via email to

[Prev in Thread] Current Thread [Next in Thread]