[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] build: avoid new chmod.c warnings from upcoming GCC12
|
From: |
Jim Meyering |
|
Subject: |
Re: [PATCH] build: avoid new chmod.c warnings from upcoming GCC12 |
|
Date: |
Thu, 16 Sep 2021 15:22:43 -0700 |
On Thu, Sep 16, 2021 at 2:44 PM Pádraig Brady <P@draigbrady.com> wrote:
> On 16/09/2021 21:30, Jim Meyering wrote:
> > I tried to build with upcoming GCC12 and with warnings + -Werror, and
> > hit one failure.
> > Here's a patch to avoid that:
>
> Cool. Small nit; it's probably best to use a trailing ,
> for our standard from of aggregate initialization. I.e.,
>
> - struct change_status ch;
> + struct change_status ch = { 0, };
Good catch, indeed. Thank you. Pushed with that correction.