coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: nstrftime.c fails to build due to memset overflow


From: Paul Eggert
Subject: Re: nstrftime.c fails to build due to memset overflow
Date: Wed, 15 Mar 2023 20:31:02 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0

On 3/15/23 16:03, Marcus Müller wrote:
introducing a macro really doesn't do readability

I don't want the macro either. Let's just leave the code alone.

I consider code paths that intentionally differ between debug and release builds

There's no need for that. Debug with the same options you use in production. This is common practice. But anyway the issue is moot if we just leave the code alone.

The original white_add macro which gcc falsely finds a -1 in, which kicked off 
this thread? That should really not be part of any code base.

That's a different topic. I agree nstrftime.c is messy. It'd be nice if someone had the time to clean it up. But in the meantime we should not make it messier just to pacify an poorly-used compiler. We should just leave the code alone.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]