[Cvs-cvs] ccvs/src ChangeLog add.c checkin.c client.c com... [cvs1-11-x-branch]

[Mark D. Baushke]

CVSROOT:        /cvsroot/cvs
Module name:    ccvs
Branch:         cvs1-11-x-branch
Changes by:     Mark D. Baushke <address@hidden>        06/05/31 15:15:56

Modified files:
        src            : ChangeLog add.c checkin.c client.c commit.c 
                         rcs.c 

Log message:
        * add.c (add): Fix memory leak.
        [Fixes NetBSD coverity cid-3751.]
        (add_directory): Fix memory leak.
        [Fixes NetBSD coverity cid-3640.]
        
        * commit.c (remove_file): Fix memory leak.
        [Fixes NetBSD coverity cid-3752.]
        
        * checkin.c (Checkin): Avoid possible NULL dereference.
        [Fixes NetBSD coverity cid-2425.]
        
        * client.c (auth_server): Fix memory leak.
        [Fixes NetBSD coverity cid-3404.]
        
        * rcs.c (RCS_checkin): Add assert (tip).
        [Fixes NetBSD coverity cid-2424.]

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/cvs/ccvs/src/ChangeLog.diff?only_with_tag=cvs1-11-x-branch&tr1=1.2336.2.454&tr2=1.2336.2.455&r1=text&r2=text
http://cvs.savannah.gnu.org/viewcvs/cvs/ccvs/src/add.c.diff?only_with_tag=cvs1-11-x-branch&tr1=1.80.2.26&tr2=1.80.2.27&r1=text&r2=text
http://cvs.savannah.gnu.org/viewcvs/cvs/ccvs/src/checkin.c.diff?only_with_tag=cvs1-11-x-branch&tr1=1.41.8.6&tr2=1.41.8.7&r1=text&r2=text
http://cvs.savannah.gnu.org/viewcvs/cvs/ccvs/src/client.c.diff?only_with_tag=cvs1-11-x-branch&tr1=1.318.4.40&tr2=1.318.4.41&r1=text&r2=text
http://cvs.savannah.gnu.org/viewcvs/cvs/ccvs/src/commit.c.diff?only_with_tag=cvs1-11-x-branch&tr1=1.187.4.37&tr2=1.187.4.38&r1=text&r2=text
http://cvs.savannah.gnu.org/viewcvs/cvs/ccvs/src/rcs.c.diff?only_with_tag=cvs1-11-x-branch&tr1=1.262.4.54&tr2=1.262.4.55&r1=text&r2=text

Patches:
Index: ccvs/src/ChangeLog
diff -u ccvs/src/ChangeLog:1.2336.2.454 ccvs/src/ChangeLog:1.2336.2.455
--- ccvs/src/ChangeLog:1.2336.2.454     Fri May 26 16:25:24 2006
+++ ccvs/src/ChangeLog  Wed May 31 15:15:55 2006
@@ -1,3 +1,22 @@
+2006-05-31  Mark D. Baushke  <address@hidden>
+
+       * add.c (add): Fix memory leak.
+       [Fixes NetBSD coverity cid-3751.]
+       (add_directory): Fix memory leak.
+       [Fixes NetBSD coverity cid-3640.]
+
+       * checkin.c (Checkin): Avoid possible NULL dereference.
+       [Fixes NetBSD coverity cid-2425.]
+
+       * client.c (auth_server): Fix memory leak.
+       [Fixes NetBSD coverity cid-3404.]
+
+       * commit.c (remove_file): Fix memory leak.
+       [Fixes NetBSD coverity cid-3752.]
+
+       * rcs.c (RCS_checkin): Add assert (tip).
+       [Fixes NetBSD coverity cid-2424.]
+
 2006-05-26  Mark D. Baushke  <address@hidden>
 
        * add.c (add): Do not leak memory.
Index: ccvs/src/add.c
diff -u ccvs/src/add.c:1.80.2.26 ccvs/src/add.c:1.80.2.27
--- ccvs/src/add.c:1.80.2.26    Fri May 26 16:25:25 2006
+++ ccvs/src/add.c      Wed May 31 15:15:56 2006
@@ -168,6 +168,8 @@
               nothing, it would spit back a usage message).  */
            if (options)
                free (options);
+           if (message)
+               free (message);
            return err;
        }
 
@@ -844,7 +846,10 @@
        fileattr_write ();
        fileattr_free ();
        if (attrs != NULL)
+       {
            free (attrs);
+           attrs = NULL;
+       }
 
        /*
         * Set up an update list with a single title node for Update_Logfile
@@ -882,6 +887,8 @@
 
     free (rcsdir);
     free (message);
+    if (attrs != NULL)
+       free (attrs);
 
     return 0;
 
Index: ccvs/src/checkin.c
diff -u ccvs/src/checkin.c:1.41.8.6 ccvs/src/checkin.c:1.41.8.7
--- ccvs/src/checkin.c:1.41.8.6 Mon Jan 31 22:15:10 2005
+++ ccvs/src/checkin.c  Wed May 31 15:15:56 2006
@@ -79,7 +79,8 @@
               changes is if the file contains RCS keywords.  So we if
               we are not expanding RCS keywords, we are done.  */
 
-           if (strcmp (options, "-V4") == 0) /* upgrade to V5 now */
+           if (options != NULL
+               && strcmp (options, "-V4") == 0) /* upgrade to V5 now */
                options[0] = '\0';
 
            /* FIXME: If PreservePermissions is on, RCS_cmp_file is
Index: ccvs/src/client.c
diff -u ccvs/src/client.c:1.318.4.40 ccvs/src/client.c:1.318.4.41
--- ccvs/src/client.c:1.318.4.40        Fri May 26 04:21:51 2006
+++ ccvs/src/client.c   Wed May 31 15:15:56 2006
@@ -3921,6 +3921,7 @@
 
         /* Paranoia. */
         memset (password, 0, strlen (password));
+       free (password);
 # else /* ! AUTH_CLIENT_SUPPORT */
        error (1, 0, "INTERNAL ERROR: This client does not support pserver 
authentication");
 # endif /* AUTH_CLIENT_SUPPORT */
Index: ccvs/src/commit.c
diff -u ccvs/src/commit.c:1.187.4.37 ccvs/src/commit.c:1.187.4.38
--- ccvs/src/commit.c:1.187.4.37        Fri May 12 15:17:38 2006
+++ ccvs/src/commit.c   Wed May 31 15:15:56 2006
@@ -1744,6 +1744,8 @@
        if (!quiet)
            error (0, retcode == -1 ? errno : 0,
                   "failed to commit dead revision for `%s'", finfo->fullname);
+       if (prev_rev != NULL)
+           free (prev_rev);
        return 1;
     }
     /* At this point, the file has been committed as removed.  We should
Index: ccvs/src/rcs.c
diff -u ccvs/src/rcs.c:1.262.4.54 ccvs/src/rcs.c:1.262.4.55
--- ccvs/src/rcs.c:1.262.4.54   Fri May 26 16:25:25 2006
+++ ccvs/src/rcs.c      Wed May 31 15:15:56 2006
@@ -5356,6 +5356,7 @@
        if (dots == 0)
        {
            tip = xstrdup (rcs->head);
+           assert (tip != NULL);
            if (atoi (tip) != atoi (branch))
            {
                newrev = (char *) xrealloc (newrev, strlen (newrev) + 3);