[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Cvs-cvs] ccvs/src ChangeLog admin.c

From: Derek R. Price
Subject: Re: [Cvs-cvs] ccvs/src ChangeLog admin.c
Date: Tue, 13 Jun 2006 15:58:20 -0400
User-agent: Thunderbird (Windows/20060516)

Larry Jones wrote:
> Wrong fix, Derek.  The is*() functions want unsigned chars, so you
> shouldn't change the type of s.  Either add an explicit cast to the
> initialization or change the type of src -- it just depends how far
> upstream you want to push the changes.

Yeah, but the is* functions don't issue warnings when the wrong type is
passed to them, at least in my environment.  Also, a typecast could
conceivably mask problems in the future (for example, if someone munged
a search/replace and deleted the `const' off of src's decl).

I'd prefer to leave this as it is unless there are systems where my
version causes warnings to be issued or causes some other problems.


Derek R. Price
CVS Solutions Architect
Get CVS support at Ximbiot <>!
v: +1 248.835.1260
f: +1 248.835.1263

reply via email to

[Prev in Thread] Current Thread [Next in Thread]