[Cvs-cvs] ccvs/src sign.c verify.c ChangeLog

[Jim Hyslop]

CVSROOT:        /cvsroot/cvs
Module name:    ccvs
Changes by:     Jim Hyslop <jhyslop>    06/06/24 02:19:19

Modified files:
        src            : sign.c verify.c ChangeLog 

Log message:
                * sign.c, verify.c: back out "b" changes made earlier today - 
not
                supported by popen on other platforms.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/ccvs/src/sign.c?cvsroot=cvs&r1=1.9&r2=1.10
http://cvs.savannah.gnu.org/viewcvs/ccvs/src/verify.c?cvsroot=cvs&r1=1.6&r2=1.7
http://cvs.savannah.gnu.org/viewcvs/ccvs/src/ChangeLog?cvsroot=cvs&r1=1.3455&r2=1.3456

Patches:
Index: sign.c
===================================================================
RCS file: /cvsroot/cvs/ccvs/src/sign.c,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -b -r1.9 -r1.10
--- sign.c      23 Jun 2006 20:46:39 -0000      1.9
+++ sign.c      24 Jun 2006 02:19:19 -0000      1.10
@@ -295,7 +295,7 @@
        error (1, 0, "sign template resolved to the empty string!");
 
     noexec = false;
-    if (!(pipefp = run_popen (cmdline, "rb")))
+    if (!(pipefp = run_popen (cmdline, "r")))
        error (1, errno, "failed to execute signature generator");
     noexec = save_noexec;
 

Index: verify.c
===================================================================
RCS file: /cvsroot/cvs/ccvs/src/verify.c,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -b -r1.6 -r1.7
--- verify.c    23 Jun 2006 20:46:39 -0000      1.6
+++ verify.c    24 Jun 2006 02:19:19 -0000      1.7
@@ -420,7 +420,7 @@
     }
 
     noexec = false;
-    if (!(pipefp = run_popen (cmdline, "wb")))
+    if (!(pipefp = run_popen (cmdline, "w")))
     {
        error (fatal, errno, "failed to execute signature verifier");
        retval = false;

Index: ChangeLog
===================================================================
RCS file: /cvsroot/cvs/ccvs/src/ChangeLog,v
retrieving revision 1.3455
retrieving revision 1.3456
diff -u -b -r1.3455 -r1.3456
--- ChangeLog   23 Jun 2006 20:46:38 -0000      1.3455
+++ ChangeLog   24 Jun 2006 02:19:19 -0000      1.3456
@@ -1,7 +1,11 @@
 2006-06-24  Jim Hyslop <address@hidden>
 
+       * sign.c, verify.c: back out "b" changes made earlier today - not
+       supported by popen on other platforms.
+
        * diff.c: use unlink_file instead of CVS_UNLINK (which resolves to
        unlink) because on Windows, unlink doesn't remove read-only files.
+
        * sign.c, subr.c, verify.c: add "b" (binary) flag to open the files
        and pipes in binary mode (on Windows, CRLF translation really confuses
        gpg).