[Cvs-cvs] ccvs/src ChangeLog login.c [cvs1-11-x-branch]

[Derek Robert Price]

CVSROOT:        /cvsroot/cvs
Module name:    ccvs
Branch:         cvs1-11-x-branch
Changes by:     Derek Robert Price <dprice>     06/06/28 14:02:34

Modified files:
        src            : ChangeLog login.c 

Log message:
        [bug #16961]
        * login.c (get_cvs_password): Return copy of global variable.
        (Patch from <address@hidden>.)

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/ccvs/src/ChangeLog?cvsroot=cvs&only_with_tag=cvs1-11-x-branch&r1=1.2336.2.461&r2=1.2336.2.462
http://cvs.savannah.gnu.org/viewcvs/ccvs/src/login.c?cvsroot=cvs&only_with_tag=cvs1-11-x-branch&r1=1.70.4.7&r2=1.70.4.8

Patches:
Index: ChangeLog
===================================================================
RCS file: /cvsroot/cvs/ccvs/src/ChangeLog,v
retrieving revision 1.2336.2.461
retrieving revision 1.2336.2.462
diff -u -b -r1.2336.2.461 -r1.2336.2.462
--- ChangeLog   23 Jun 2006 18:58:47 -0000      1.2336.2.461
+++ ChangeLog   28 Jun 2006 14:02:34 -0000      1.2336.2.462
@@ -1,3 +1,9 @@
+2006-06-28  Derek Price  <address@hidden>
+
+       [bug #16961]
+       * login.c (get_cvs_password): Return copy of global variable.
+       (Patch from <address@hidden>.)
+
 2006-06-23  Larry Jones  <address@hidden>
 
        * server.c (do_cvs_command): Remove unused variable.

Index: login.c
===================================================================
RCS file: /cvsroot/cvs/ccvs/src/login.c,v
retrieving revision 1.70.4.7
retrieving revision 1.70.4.8
diff -u -b -r1.70.4.7 -r1.70.4.8
--- login.c     4 May 2006 09:53:09 -0000       1.70.4.7
+++ login.c     28 Jun 2006 14:02:34 -0000      1.70.4.8
@@ -578,9 +578,10 @@
 
 
 
-/* Returns the _scrambled_ password.  The server must descramble
-   before hashing and comparing.  If password file not found, or
-   password not found in the file, just return NULL. */
+/* Returns the _scrambled_ password in freshly allocated memory.  The server
+ * must descramble before hashing and comparing.  If password file not found,
+ * or password not found in the file, just return NULL.
+ */
 char *
 get_cvs_password ()
 {
@@ -591,7 +592,7 @@
        context, then assume they have supplied the correct, scrambled
        password. */
     if (cvs_password)
-       return cvs_password;
+       return xstrdup (cvs_password);
 
     if (getenv ("CVS_PASSWORD") != NULL)
     {